Re: [DynInst_API:] boost 1.70 breaks dyninst build over checked_delete

[Tim Haines <thaines.astro@xxxxxxxxx>]

That's a good point. It would depend on how BOOST_CONSTEXPR is defined. I think you are probably right in that it likely is set to constexpr before 1.70 (I'm not sure when C++11 was officially supported in Boost). That would require us to check the Boost version before decorating the friend declaration (Ugh. macro checks are the worst).

On Mon, Apr 15, 2019 at 3:15 PM Mark W. Krentel <krentel@xxxxxxxx> wrote:

Will that solution work for both 1.69 and 1.70?

That would be the most robust way of handling this, if there's a
solution that will work either way, or else a config test and #if.

You'd rather not have a hard line where Dyninst 10.0 requires <= 1.69
and Dyninst 10.1 requires >= 1.70.

Thanks!

--Mark

P.S. This is what cron jobs are for. I noticed as soon as it was
pulled into spack.



On 04/15/19 14:55, Tim Haines wrote:
> Hi, Mark.
>
> I saw that 1.70 had been released and put it on my TODO list to test
> with Dyninst, so thanks for checking that off for me! The underlying
> issue is that the Breakpoint class has marked boost::checked_delete as
> a friend which is weird because it doesn't access any members of the
> passed object. I guessing that just marking the friend declaration
> BOOST_NOEXCEPT will probably fix the issue.
>
> Thanks.
>
> - Tim
>