Re: [Gems-users] A minor bug in LogTM protocol

[郭锐 <timmyguo@xxxxxxxxxxxxxxxx>]

Thanks for your reply.
The ii_allocateL1DCacheBlock action in IS/Retry transition should only clear
the flags (Trans, Logged, Read, Write, Permission are all cleared). It will
affect the profile message in this way:
The controller will call profileTransactionLoad() method to do some
profiling in the h_load_hit action if the 'Trans' flag of the cache line is
set. The Trans flag of a cache line is only set when the controller begin to
serve the LD_XACT/ST_XACT request. If the cache line in question was in "I"
state before the request, it will transit to IS state to wait for Data or
Nack message. And if it got nacked, a Retry will finally trigger and thus
clear the Trans flag of the cache line as I described above. 

Currently, the profileTransactionLoad() method only print some messages on
the screen when "PROFILE_XACT" is set to true, So it doesn't really harmful.
But what if one choose to add some serious statistics in this method? 
> -----Original Message-----
> From: gems-users-bounces@xxxxxxxxxxx
[mailto:gems-users-bounces@xxxxxxxxxxx]
> On Behalf Of Kevin Moore
> Sent: Thursday, April 26, 2007 4:31 AM
> To: Gems Users
> Subject: Re: [Gems-users] A minor bug in LogTM protocol
> 
> G.R.,
> 	That's a good point.  We don't need to allocate an L1 block
> there since one should have been allocated on the first load
> or load_xact event.  Can you elaborate on the missing
> profile messages?  Thanks,
> 
> Kevin
> 
> ?? wrote:
> > In IS/Retry transition, there is an ii_allocateL1DCacheBlock action
which
> > will clear out the Trans, Read and Write bit of the cache line. So a
Retried
> > LD_XACT will result in Trans bit set to false. While the Read bit will
be
> > set when the data is received so as to function correctly, the wrong
Trans
> > flag will result in missing of some profile messages.
> >
> > I think it's redundant and troublesome to put this action there. How do
you
> > think about it?
> >
> > G.R.
> >
> > _______________________________________________
> > Gems-users mailing list
> > Gems-users@xxxxxxxxxxx
> > https://lists.cs.wisc.edu/mailman/listinfo/gems-users
> > Use Google to search the GEMS Users mailing list by adding
> "site:https://lists.cs.wisc.edu/archive/gems-users/"; to your search.
> 
> _______________________________________________
> Gems-users mailing list
> Gems-users@xxxxxxxxxxx
> https://lists.cs.wisc.edu/mailman/listinfo/gems-users
> Use Google to search the GEMS Users mailing list by adding
> "site:https://lists.cs.wisc.edu/archive/gems-users/"; to your search.