Re: [HTCondor-users] Bug in Python Bindings: Segfault during queue_with_itemdata

[Mark Coatsworth <coatsworth@xxxxxxxxxxx>]

Hi Paul thank you, this is super helpful!

The obvious downside to Github Issues as you mentioned is that we don't currently use it. We've talked internally about switching to this, and I still think it's the best solution for all the reasons you described. But it's a big change and unlikely to happen soon.

In the short term, I'm writing up a new page for our manual (http://htcondor.readthedocs.io) called "Bug Reporting and Technical Support" that will describe all our current approaches. We'll publish it along with a new version of the manual with our 8.9.7 release expected by the end of April. I'll send a link when it's ready.

Mark

On Tue, Apr 21, 2020 at 9:05 AM Paul Skopnik <paul@xxxxxxxxxx> wrote:

Hey Mark,

I too think that GitHub would be the best place, if you are willing to
switch to another tracker for all your activity.

* It's the expected location: Right next to the code, the documentation
  and the pull requests.

* The interface will be familiar to many. Public visibility does not
  mean there is engagement and a familiar UI will help to lower the
  barrier.
  I assume many who operate and use HTCondor already have a GitHub
  account.

* The issue feature has proven itself to be powerful enough for large
  projects. Labels and project boards could be used to imitate the
  essential features of your current tracker. Bots can be integrated via
  the API for advanced functionality.

Cheers,
Paul

On 20/04/2020 22:55, Mark Coatsworth wrote:
> Hi Paul, we talked in our weekly meeting today about the lack of clarity
> for submitting a bug report. Everybody agreed we need to make this
> better. My personal opinion is that github issues are the best way to do
> this because:
>
> * It's a very centralized location, directly connected with our
> publicly-available codebase
> * Github issues are unlikely to slip through the cracks, whereas emails
> get lost
> * Github issues are publicly viewable which keeps us accountable
>
> If you have any thoughts I'd love to hear them. Also would love to hear
> from anybody else who has opinions about this :)
>
> Mark
>
> On Sun, Apr 19, 2020 at 10:16 AM Paul Skopnik <paul@xxxxxxxxxx
> <mailto:paul@xxxxxxxxxx>> wrote:
>
>     Hey List,
>
>     I've stumbled upon a bug in the Python Bindings v8.9.6. I'm writing here
>     as there is no clear way to submit a ticket (might require an account?).
>
>     The Submit.queue_with_itemdata method causes a segmentation fault when
>     the iterator passed raises an exception during next(it).
>     Submit.queue_with_itemdata() should check whether an exception occurred
>     during next(it) and pass on this exception to its Python caller.
>
>     Minimal reproducible example:
>
>     ```
>     import htcondor
>     def my_it():
>         raise Exception()
>         yield {}
>
>     sub = htcondor.Submit()
>     schedd = htcondor.Schedd()
>     with schedd.transaction() as txn:
>         result = sub.queue_with_itemdata(txn, itemdata=my_it())
>     ```
>
>     #6721 ([1]) also describes various segmentation faults, but these are
>     probably unrelated. I presume this segfault occurs because callers of
>     [2] do not check for a Python exception and thus use invalid data at
>     some point.
>
>     Cheers,
>     Paul Skopnik
>
>     [1]: https://htcondor-wiki.cs.wisc.edu/index.cgi/tktview?tn=6721
>     [2]:
>     https://github.com/htcondor/htcondor/blob/V8_9_6-branch/src/python-bindings/schedd.cpp#L636
>     _______________________________________________
>     HTCondor-users mailing list
>     To unsubscribe, send a message to htcondor-users-request@xxxxxxxxxxx
>     <mailto:htcondor-users-request@xxxxxxxxxxx> with a
>     subject: Unsubscribe
>     You can also unsubscribe by visiting
>     https://lists.cs.wisc.edu/mailman/listinfo/htcondor-users
>
>     The archives can be found at:
>     https://lists.cs.wisc.edu/archive/htcondor-users/
>
>
>
> --
> Mark Coatsworth
> Systems Programmer
> Center for High Throughput Computing
> Department of Computer Sciences
> University of Wisconsin-Madison
>
> _______________________________________________
> HTCondor-users mailing list
> To unsubscribe, send a message to htcondor-users-request@xxxxxxxxxxx with a
> subject: Unsubscribe
> You can also unsubscribe by visiting
> https://lists.cs.wisc.edu/mailman/listinfo/htcondor-users
>
> The archives can be found at:
> https://lists.cs.wisc.edu/archive/htcondor-users/
>
_______________________________________________
HTCondor-users mailing list
To unsubscribe, send a message to htcondor-users-request@xxxxxxxxxxx with a
subject: Unsubscribe
You can also unsubscribe by visiting
https://lists.cs.wisc.edu/mailman/listinfo/htcondor-users

The archives can be found at:
https://lists.cs.wisc.edu/archive/htcondor-users/

--

Mark Coatsworth

Systems Programmer

Center for High Throughput Computing

Department of Computer Sciences

University of Wisconsin-Madison